Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an aggregate from subset of messages #185

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Create an aggregate from subset of messages #185

merged 2 commits into from
Mar 19, 2024

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Feb 22, 2024 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature

Required reviews:

  • 1

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec force-pushed the aggregate-from-subset branch 2 times, most recently from f0e61fe to 2726ae0 Compare February 28, 2024 13:56
@piotr-roslaniec piotr-roslaniec force-pushed the aggregate-from-subset branch 2 times, most recently from 31383b0 to 0e27a90 Compare March 13, 2024 21:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.56776% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 79.98%. Comparing base (2fe8753) to head (18487e6).

Files Patch % Lines
ferveo/src/api.rs 94.34% 38 Missing ⚠️
ferveo-tdec/src/decryption.rs 39.13% 14 Missing ⚠️
ferveo/src/bindings_python.rs 61.11% 14 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 12 Missing ⚠️
ferveo/src/dkg.rs 94.38% 5 Missing ⚠️
ferveo/src/refresh.rs 98.54% 5 Missing ⚠️
ferveo-tdec/src/key_share.rs 50.00% 3 Missing ⚠️
ferveo-common/src/keypair.rs 0.00% 1 Missing ⚠️
ferveo/src/pvss.rs 99.20% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   78.16%   79.98%   +1.81%     
==========================================
  Files          24       24              
  Lines        5222     5876     +654     
==========================================
+ Hits         4082     4700     +618     
- Misses       1140     1176      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec force-pushed the aggregate-from-subset branch 4 times, most recently from a932aba to 18487e6 Compare March 14, 2024 09:57
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review March 14, 2024 10:11
@piotr-roslaniec piotr-roslaniec changed the base branch from main to rocknroll March 19, 2024 09:57
@cygnusv cygnusv changed the base branch from rocknroll to main March 19, 2024 11:42
@cygnusv cygnusv changed the base branch from main to rocknroll March 19, 2024 11:42
@cygnusv
Copy link
Member

cygnusv commented Mar 19, 2024

Approved as part of the R&R epic. This is currently used as the basis of #186 (still WIP), so any relevant comments can be addressed by #186

@cygnusv cygnusv merged commit 299a471 into nucypher:rocknroll Mar 19, 2024
11 checks passed
This was referenced Mar 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@piotr-roslaniec @codecov-commenter @cygnusv